Skip to content

Fix some Azalea/Lotus logic not working on Controller 0 #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tbejos wants to merge 2 commits into
base: fwk-lotus-azalea-19573
Choose a base branch
from
+3 −3
Open

Fix some Azalea/Lotus logic not working on Controller 0 #79

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3120ec
fwk: fix PD charge ceiling ignoring controller when not source
tbejos Mar 27, 2026
60d8941
fwk: Fix cypress error recovery never sent to port 1+
tbejos Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions zephyr/program/framework/src/cypress_pd_common.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1268,7 +1268,7 @@ static void cypd_update_port_state(int controller, int port)

/*
* The port can have several states active:
* 1. Type C active (with no PD contract) CC resistor negociation only
* 1. Type C active (with no PD contract) CC resistor negotiation only
* 2. Type C active with PD contract
* 3. Not active
* Each of 1 and 2 can be either source or sink
Expand All @@ -1280,7 +1280,7 @@ static void cypd_update_port_state(int controller, int port)
type_c_current);
} else {
typec_set_input_current_limit(port_idx, 0, 0);
charge_manager_set_ceil(port,
charge_manager_set_ceil(port_idx,
CEIL_REQUESTOR_PD,
CHARGE_CEIL_NONE);
}
Expand Down Expand Up @@ -1440,7 +1440,7 @@ static void perform_error_recovery(int controller)
battery_get_disconnect_state() != BATTERY_NOT_DISCONNECTED)) {

data[0] = PORT_TO_CONTROLLER_PORT(i);
cypd_write_reg_block(PORT_TO_CONTROLLER(i),
cypd_write_reg_block(controller,
CCG_DPM_CMD_REG,
data, 2);
}
Expand Down
Loading