Fix some Azalea/Lotus logic not working on Controller 0#79
Open
tbejos wants to merge 2 commits intoFrameworkComputer:fwk-lotus-azalea-19573from
Open
Fix some Azalea/Lotus logic not working on Controller 0#79tbejos wants to merge 2 commits intoFrameworkComputer:fwk-lotus-azalea-19573from
tbejos wants to merge 2 commits intoFrameworkComputer:fwk-lotus-azalea-19573from
Conversation
This fixes an issue where it would set the ceiling value on just the port value, meaning it would always go to the same controller even when it should be applying to a different controller.
There was a bug where when looping through the ports for a given controller, it would try to get the controller from the port value. This would always be zero as it is just looping.
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
kiram9
added a commit
that referenced
this pull request
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Looking through the embedded controller code I found 2 areas where it seems to ignore any controller other than 0
portand notport_idxso it doesn't pass controller information along meaning that will always send to controller 0.