Skip to content

DrDroid AI: Fix: ClickHouse Decimal math overflow in SigNoz v0.45+ #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
doctor-droid-app wants to merge 1 commit into
base: master
Choose a base branch
from
Open

DrDroid AI: Fix: ClickHouse Decimal math overflow in SigNoz v0.45+ #137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 21 additions & 15 deletions drdroid_debug_toolkit/core/integrations/source_api_processors/signoz_api_processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ def to_ms(ts):
default_traces_fields = [
{"dataType": "string", "id": "serviceName--string--tag--true", "isColumn": True, "isJSON": False, "key": "serviceName", "type": "tag"},
{"dataType": "string", "id": "name--string--tag--true", "isColumn": True, "isJSON": False, "key": "name", "type": "tag"},
{"dataType": "float64", "id": "durationNano--float64--tag--true", "isColumn": True, "isJSON": False, "key": "durationNano", "type": "tag"},
{"dataType": "int64", "id": "durationNano--int64--tag--true", "isColumn": True, "isJSON": False, "key": "durationNano", "type": "tag"},
{"dataType": "string", "id": "httpMethod--string--tag--true", "isColumn": True, "isJSON": False, "key": "httpMethod", "type": "tag"},
{"dataType": "string", "id": "responseStatusCode--string--tag--true", "isColumn": True, "isJSON": False, "key": "responseStatusCode", "type": "tag"}
]
Expand Down Expand Up @@ -228,7 +228,7 @@ def to_ms(ts):
"p50": {
"dataSource": "traces",
"aggregateOperator": "p50",
"aggregateAttribute": {"key": "durationNano", "dataType": "float64", "isColumn": True, "type": "tag"},
"aggregateAttribute": {"key": "durationNano", "dataType": "int64", "isColumn": True, "type": "tag"},
"timeAggregation": "",
"spaceAggregation": "p50",
"functions": [],
Expand All @@ -246,7 +246,7 @@ def to_ms(ts):
"p90": {
"dataSource": "traces",
"aggregateOperator": "p90",
"aggregateAttribute": {"key": "durationNano", "dataType": "float64", "isColumn": True, "type": "tag"},
"aggregateAttribute": {"key": "durationNano", "dataType": "int64", "isColumn": True, "type": "tag"},
"timeAggregation": "",
"spaceAggregation": "p90",
"functions": [],
Expand All @@ -264,7 +264,7 @@ def to_ms(ts):
"p99": {
"dataSource": "traces",
"aggregateOperator": "p99",
"aggregateAttribute": {"key": "durationNano", "dataType": "float64", "isColumn": True, "type": "tag"},
"aggregateAttribute": {"key": "durationNano", "dataType": "int64", "isColumn": True, "type": "tag"},
"timeAggregation": "",
"spaceAggregation": "p99",
"functions": [],
Expand Down Expand Up @@ -696,14 +696,20 @@ def fetch_services(self, start_time=None, end_time=None, duration=None):
end_ns = int(end_dt.timestamp() * 1_000_000_000)

try:
url = f"{self.signoz_api_url}/api/v1/services"
payload = {"start": str(start_ns), "end": str(end_ns), "tags": []}
response = requests.post(url, headers=self.headers, json=payload, timeout=120)
if response.status_code == 200:
return response.json()
else:
logger.error(f"Failed to fetch services: {response.status_code} - {response.text}")
return {"status": "error", "message": f"Failed to fetch services: {response.status_code}", "details": response.text}
# Use direct ClickHouse SQL query to avoid Decimal math overflow (ClickHouse error 407)
# that occurs in SigNoz v0.45+ when /api/v1/services runs avg(durationNano) on Decimal128(9)
query = (
"SELECT serviceName, count() as span_count "
"FROM signoz_traces.distributed_signoz_index_v3 "
f"WHERE timestamp >= toDateTime64({int(start_dt.timestamp())}, 9) "
f"AND timestamp <= toDateTime64({int(end_dt.timestamp())}, 9) "
"GROUP BY serviceName ORDER BY span_count DESC LIMIT 1000"
)
return self.signoz_query_clickhouse(
query=query,
time_geq=int(start_dt.timestamp()),
time_lt=int(end_dt.timestamp()),
)
except Exception as e:
logger.error(f"Exception when fetching services: {e}")
return {"status": "error", "message": str(e)}
Expand Down Expand Up @@ -1398,7 +1404,7 @@ def fetch_traces_or_logs(self, data_type, start_time=None, end_time=None, durati
if data_type == "traces":
# For traces, use ClickHouse SQL approach
table = "signoz_traces.distributed_signoz_index_v3"
select_cols = "traceID, serviceName, name, durationNano, statusCode, timestamp"
select_cols = "traceID, serviceName, name, toFloat64(durationNano) AS durationNano, statusCode, timestamp"
where_clauses = [
f"timestamp >= toDateTime64({int(start_dt.timestamp())}, 9)",
f"timestamp < toDateTime64({int(end_dt.timestamp())}, 9)"
Expand Down Expand Up @@ -1704,7 +1710,7 @@ def fetch_traces_with_filters(self, filter_expression, start_time=None, end_time

# Use ClickHouse SQL approach with correct column names (same as working fetch_traces_or_logs)
table = "signoz_traces.distributed_signoz_index_v3"
select_cols = "traceID, spanID, serviceName, name, durationNano, statusCode, timestamp, httpMethod, httpUrl"
select_cols = "traceID, spanID, serviceName, name, toFloat64(durationNano) AS durationNano, statusCode, timestamp, httpMethod, httpUrl"
where_clauses = [
f"timestamp >= toDateTime64({int(start_dt.timestamp())}, 9)",
f"timestamp < toDateTime64({int(end_dt.timestamp())}, 9)"
Expand Down Expand Up @@ -1954,7 +1960,7 @@ def get_trace_spans(self, trace_id, include_attributes=True, limit=100):

# Use ClickHouse SQL approach (same as existing working code)
table = "signoz_traces.distributed_signoz_index_v3"
select_cols = "traceID, spanID, serviceName, name, durationNano, statusCode, timestamp"
select_cols = "traceID, spanID, serviceName, name, toFloat64(durationNano) AS durationNano, statusCode, timestamp"
where_clauses = [
f"timestamp >= toDateTime64({int(start_dt.timestamp())}, 9)",
f"timestamp < toDateTime64({int(end_dt.timestamp())}, 9)",
Expand Down