DrDroid AI: Fix: ClickHouse Decimal math overflow in SigNoz v0.45+#137
Open
doctor-droid-app[bot] wants to merge 1 commit intomasterfrom
Open
DrDroid AI: Fix: ClickHouse Decimal math overflow in SigNoz v0.45+#137doctor-droid-app[bot] wants to merge 1 commit intomasterfrom
doctor-droid-app[bot] wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed a ClickHouse error 407 (Decimal math overflow) caused by aggregation functions running on the
durationNanocolumn after it changed from UInt64 to Decimal128(9) in SigNoz v0.45+.Changes
fetch_services()call to/api/v1/serviceswith a direct ClickHouse SQL query that avoids any Decimal aggregation ondurationNanodurationNanofield dataType declarations fromfloat64toint64in the default traces fields and latency metric query templatestoFloat64()casting fordurationNanoin the SELECT columns of three raw SQL queries to prevent type errors when returning the column valueTesting
fetch_services()no longer calls the SigNoz endpoint that internally runsavg(durationNano)andquantile()(durationNano)on the Decimal columnserviceNamewith a simplecount(), avoiding any Decimal math operationsdurationNanoto float64 before returning resultsThis PR is created as part of investigation https://aiops.drdroid.io/?investigation_id=b9697645-fc65-4632-be14-e016bf899584