Skip to content

fix: Vertically center Banner text content when action or close button is present #1029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
engfragui merged 6 commits into from
Apr 7, 2026
Merged

fix: Vertically center Banner text content when action or close button is present #1029

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6cce3ae
fix: vertically center Banner text content when action or close butto…
engfragui Apr 6, 2026
99190ec
chore: revert auto-generated react-compiler tracking changes
engfragui Apr 6, 2026
d0f7d79
fix: revert .content align-items to flex-start to avoid mobile center…
engfragui Apr 6, 2026
006ca88
fix: restructure Banner layout to properly align icon with first line…
engfragui Apr 6, 2026
2c6268c
fix: restore narrow-width layout for type icon and close button
engfragui Apr 6, 2026
0c20a08
chore: revert auto-generated react-compiler tracking changes
engfragui Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 11 additions & 17 deletions src/banner/banner.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,17 +59,15 @@
}

.image img,
.icon svg {
.typeIcon svg {
display: block;
}

/* The close button is invisible in this resolution, so we're hiding the container to prevent flex-gap from making extra space */
.icon:empty,
.icon:has(.closeButton:only-child) {
.typeIcon:empty {
display: none;
}

.icon .closeButton {
.iconCopy .closeButton {
display: none;
}

Expand All @@ -88,24 +86,20 @@
.content {
flex-direction: column;
}
.icon {
display: flex;
width: 100%;
align-items: center;
justify-content: space-between;
}
.topContent {
flex-direction: column;
align-items: stretch;
}
.icon:has(.closeButton:only-child) {
display: flex;
.iconCopy {
flex-direction: row;
align-items: center;
justify-content: space-between;
}
.icon .closeButton {
display: flex;
.iconCopy:has(.typeIcon:empty) {
justify-content: flex-end;
}
.icon .closeButton:only-child {
margin-left: auto;
.iconCopy .closeButton {
display: flex;
}
.actions {
align-self: flex-start;
Expand Down
72 changes: 43 additions & 29 deletions src/banner/banner.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,48 +156,62 @@ const Banner = React.forwardRef<HTMLDivElement, BannerProps>(function Banner(
{image ? <Box className={styles.image}>{image}</Box> : null}

<Box className={styles.content} display="flex" gap="small">
<Box className={styles.icon}>
{type === 'neutral' ? icon : <BannerIcon type={type} />}
{closeButton}
</Box>

<Box display="flex" flexDirection="column" gap="small" flexGrow={1}>
<Box
className={styles.topContent}
display="flex"
gap="small"
alignItems="flexStart"
alignItems="center"
>
<Box
className={styles.copy}
className={styles.iconCopy}
display="flex"
flexDirection="column"
gap="small"
alignItems="flexStart"
flexGrow={1}
>
{title ? (
<Box id={titleId} className={styles.title}>
{title}
</Box>
) : null}
<Box className={styles.typeIcon}>
{type === 'neutral' ? icon : <BannerIcon type={type} />}
</Box>
<Box
id={descriptionId}
className={[styles.description, title ? styles.secondary : null]}
className={styles.copy}
display="flex"
flexDirection="column"
flexGrow={1}
>
{description}
{inlineLinks?.map(({ label, ...props }, index) => {
return (
<React.Fragment key={index}>
<TextLink
{...props}
exceptionallySetClassName={styles.inlineLink}
>
{label}
</TextLink>
{index < inlineLinks.length - 1 ? <span> · </span> : ''}
</React.Fragment>
)
})}
{title ? (
<Box id={titleId} className={styles.title}>
{title}
</Box>
) : null}
<Box
id={descriptionId}
className={[
styles.description,
title ? styles.secondary : null,
]}
>
{description}
{inlineLinks?.map(({ label, ...props }, index) => {
return (
<React.Fragment key={index}>
<TextLink
{...props}
exceptionallySetClassName={styles.inlineLink}
>
{label}
</TextLink>
{index < inlineLinks.length - 1 ? (
<span> · </span>
) : (
''
)}
</React.Fragment>
)
})}
</Box>
</Box>
{closeButton}
</Box>

{action || closeButton ? (
Expand Down
Loading