fix: Vertically center Banner text content when action or close button is present#1029
fix: Vertically center Banner text content when action or close button is present#1029
Conversation
…n is present Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
doistbot
left a comment
There was a problem hiding this comment.
This PR updates the Banner component to vertically center its text content when an action or close button is present, helping to create a more balanced layout. However, an issue was noted where applying align-items: center to the .content class inadvertently centers the text horizontally in the mobile view, alongside a minor redundancy in the desktop layout.
…ing bug Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… of text Move the type icon from the .icon container into .topContent, wrapped with .copy in a new .iconCopy group. This ensures the icon stays aligned with the first line of text while the icon+text group centers as a unit relative to action buttons. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
doistbot
left a comment
There was a problem hiding this comment.
This PR improves the visual balance of the Banner component by vertically centering its text content when an action or close button is present. While this nicely aligns the component with the design specifications, there is a layout regression in narrow containers (under 235px) where the updated structure causes the type icon and close button to inadvertently render on separate rows.
Move the close button into .iconCopy so that at <235px the type icon and close button render together in the same header row, matching the original responsive layout. The .icon container is removed entirely. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Description
Vertically centers
<Banner>'s text content when action or close button is present.Note that before this fix the text content was slightly closer to the top of the
<Banner>and not actually centered.Reference
Demo
(Storybook)
(Storybook)