-
Notifications
You must be signed in to change notification settings - Fork 66
Migrate web backend to FastAPI #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
372e035 to
58c1553
Compare
974e81d to
4d1ff84
Compare
|
This is running on custom-beta and working good. |
|
Hey @peterbarker @Williangalvani! Did you get a chance to review this? |
|
This is also a problem on the current custom build server. Build Cube Orange Plus with default parameters fails: Vehicle ID: copter
|
Williangalvani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spent a while looking through this and couldn't find anything outstanding.
Using an "Admin token" is a bit weird to me, but other than that, it looks fine.
I built a firmware locally with no issue.
@Williangalvani You mean it could have been something with lesser scope? |
This is a big PR which migrates our backend to the modern FAST API. Our existing Flask based code was cluttered and had made it very less extensible. The new fastapi based backend makes it very structured and modular.
Now our all endpoints are as per standard REST API guidelines.
The existing Flask backend was also very tricky to write end to end tests. The new backend structure also makes things easily testable and tests would follow this PR.
It also provides a self generated api documentation endpoint (/api/docs) which would help in integrating custom build server with external services like ground control stations in future.
