fix(logistics): enforce correct promise ordering for cascading factory requests#226
Open
Eldrinn-Elantey wants to merge 1 commit intozznty:masterfrom
Open
fix(logistics): enforce correct promise ordering for cascading factory requests#226Eldrinn-Elantey wants to merge 1 commit intozznty:masterfrom
Eldrinn-Elantey wants to merge 1 commit intozznty:masterfrom
Conversation
…y requests Issue: in cascading crafting requests, a parent-level Promise could be created before child-level ones, and promises could also be added when no actual requests were generated, causing crafting to stall. Changes: Switched request storage to LinkedHashMap to preserve deterministic bottom-up processing order. Added explicit tracking for contexts that produced real requests. Now creates output promises only when requests were actually generated and then fully dispatched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: in cascading crafting requests, a parent-level Promise could be created before child-level ones, and promises could also be added when no actual requests were generated, causing crafting to stall.
Changes:
Switched request storage to LinkedHashMap to preserve deterministic bottom-up processing order. Added explicit tracking for contexts that produced real requests. Now creates output promises only when requests were actually generated and then fully dispatched.