feat: add type annotations to zksync module#63
feat: add type annotations to zksync module#63comilao wants to merge 1 commit intozksync-sdk:masterfrom
Conversation
|
Could you update this branch with latests changes so that test can pass? Thank you for your contributions |
Sorry about this.
All of the above can be put inside |
|
We are planing to refactor large part of the code in the near future which will resolve typing issues, we are trying to avoid other dependencies as much as possible plan is to use native typing. The main problem lies in the design itself. We are planning to go with |
|
Thanks a lot for this comment. Glad to know your team will be revamping this repo, it really helps me a lot during my work. I have made another PR #68 to explain more about what I mean, sorry for the inconsiderate comments earlier, I can also help with some tasks if you needed help. I will also close this PR first. |
What 💻
zksyncmoduleRunning Testssection inREADME.mdbased on this workflowWhy ✋
attach_modulesdoes not provide type annotationsEvidence 📷
Before this change, hovering over



zksync, it showsAfter this change, hovering over
zksync, it showsThis provides useful function hints in the code editor
Notes 📝