fix: Signal.ref race condition from unsynchronized mutable var (#4023)#4028
Merged
fix: Signal.ref race condition from unsynchronized mutable var (#4023)#4028
Conversation
✅ Deploy Preview for zio-http ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
987Nabil
force-pushed
the
fix/datastar-signal-ref
branch
from
d8d3990 to
eceabe4
Compare
987Nabil
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix race condition in
Signal.refcaused by an unsynchronized mutablevar.Bug
Signal.refused aprivate var ref0: String = nullwith a check-and-set pattern that was not thread-safe. Concurrent access could result in null returns or duplicate computation.Fix
Replace
private var ref0+def refwithlazy val ref, which is thread-safe in Scala (uses a synchronized initialization block under the hood, zero-cost after first access).The primitive-type restriction and
RuntimeExceptionfor non-primitive types are preserved — that semantic constraint is correct and will be improved to a compile-time check in zio-http 4.Fixes #4023