fix: add missing Always and Never values to DatastarRetry#4027
Merged
fix: add missing Always and Never values to DatastarRetry#4027
Conversation
✅ Deploy Preview for zio-http ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
Adds the missing DatastarRetry enum values to the Scala Datastar SDK so it matches the Datastar protocol/JS SDK ('auto' | 'error' | 'always' | 'never') and updates schema string decoding/encoding accordingly.
Changes:
- Added
DatastarRetry.AlwaysandDatastarRetry.Nevercase objects. - Updated
Schema[String].transformOrFailmapping to support"always"and"never". - Expanded the invalid-value error message to list all four allowed values.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
226
to
233
| implicit val schema: Schema[DatastarRetry] = Schema[String].transformOrFail[DatastarRetry]( | ||
| { | ||
| case "auto" => Right(Auto) | ||
| case "error" => Right(Error) | ||
| case other => Left(s"Invalid DatastarRetry value: '$other'. Expected 'auto' or 'error'.") | ||
| case "auto" => Right(Auto) | ||
| case "error" => Right(Error) | ||
| case "always" => Right(Always) | ||
| case "never" => Right(Never) | ||
| case other => Left(s"Invalid DatastarRetry value: '$other'. Expected 'auto', 'error', 'always', or 'never'.") | ||
| }, |
Comment on lines
219
to
+224
| sealed trait DatastarRetry | ||
| object DatastarRetry { | ||
| case object Auto extends DatastarRetry | ||
| case object Error extends DatastarRetry | ||
| case object Auto extends DatastarRetry | ||
| case object Error extends DatastarRetry | ||
| case object Always extends DatastarRetry | ||
| case object Never extends DatastarRetry |
987Nabil
force-pushed
the
fix/datastar-retry-missing-enums
branch
from
de9f843 to
e84a007
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4021
The Datastar JS SDK supports
retry: 'auto' | 'error' | 'always' | 'never', but the Scala SDK was missing theAlwaysandNeverenum values.Changes
Alwayscase object toDatastarRetryNevercase object toDatastarRetry