Extracted ServerSentEvent.rawEventLines from ServerSentEvent.binaryCodec#3841
Merged
Extracted ServerSentEvent.rawEventLines from ServerSentEvent.binaryCodec#3841
ServerSentEvent.rawEventLines from ServerSentEvent.binaryCodec#3841Conversation
Kalin-Rudnicki
requested review from
987Nabil,
jdegoes,
kyri-petrou and
vigoo
as code owners
✅ Deploy Preview for zio-http ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Kalin-Rudnicki
force-pushed
the
current/feature/sse
branch
from
e258d7b to
fe8ec1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The decoding logic in
ServerSentEvent.binaryCodecdepended on decoding bytes into aChunk[String], and then using the binary codec.I split this logic out into a separate
ServerSentEvent.rawEventLinesso that this decoding logic can be used without having to provide aBinaryCodec