Skip to content

ci: pin checkout SHA; always checkout z-shell/zd in reusable workflow#64

Merged
ss-o merged 1 commit into
mainfrom
ci/fix-reusable-checkout
May 16, 2026
Merged

ci: pin checkout SHA; always checkout z-shell/zd in reusable workflow#64
ss-o merged 1 commit into
mainfrom
ci/fix-reusable-checkout

Conversation

@ss-o
Copy link
Copy Markdown
Member

@ss-o ss-o commented May 16, 2026

Problem

When test-native.yml is called as a reusable workflow from another repo (e.g. z-shell/zi), actions/checkout without an explicit repository: checks out the calling repository, not z-shell/zd. This means the tests/ directory (which lives in zd) is not present, and ZUnit fails with Test file or directory not found.

Fix

  • Pin actions/checkout to its v4 SHA
  • Add repository: z-shell/zd so the test infrastructure is always available regardless of which repo calls this workflow

The zi repository is still cloned separately via the Install zi step using zi_repo/zi_ref inputs.

Copilot AI review requested due to automatic review settings May 16, 2026 09:24
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Pins actions/checkout to a specific v4 SHA and explicitly checks out z-shell/zd so the reusable workflow has access to the tests/ directory when invoked from other repositories (e.g. z-shell/zi).

Changes:

  • Pin actions/checkout action to commit SHA for v4
  • Add explicit repository: z-shell/zd to ensure test infrastructure is checked out regardless of caller

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ss-o ss-o merged commit cbb1211 into main May 16, 2026
18 checks passed
@ss-o ss-o deleted the ci/fix-reusable-checkout branch May 16, 2026 09:28
@ss-o ss-o restored the ci/fix-reusable-checkout branch May 19, 2026 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants