ci: pin checkout SHA; always checkout z-shell/zd in reusable workflow#64
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Pins actions/checkout to a specific v4 SHA and explicitly checks out z-shell/zd so the reusable workflow has access to the tests/ directory when invoked from other repositories (e.g. z-shell/zi).
Changes:
- Pin
actions/checkoutaction to commit SHA for v4 - Add explicit
repository: z-shell/zdto ensure test infrastructure is checked out regardless of caller
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
test-native.ymlis called as a reusable workflow from another repo (e.g.z-shell/zi),actions/checkoutwithout an explicitrepository:checks out the calling repository, notz-shell/zd. This means thetests/directory (which lives in zd) is not present, and ZUnit fails withTest file or directory not found.Fix
actions/checkoutto its v4 SHArepository: z-shell/zdso the test infrastructure is always available regardless of which repo calls this workflowThe zi repository is still cloned separately via the
Install zistep usingzi_repo/zi_refinputs.