Skip to content

fix(ci): fix rclone docker build and update checksums#162

Open
ss-o wants to merge 3 commits into
mainfrom
bug-fix-ci-failures-main
Open

fix(ci): fix rclone docker build and update checksums#162
ss-o wants to merge 3 commits into
mainfrom
bug-fix-ci-failures-main

Conversation

@ss-o
Copy link
Copy Markdown
Member

@ss-o ss-o commented May 16, 2026

This PR fixes the CI failures on main branch:

  1. Updated rclone and commit actions to v1.1.0 (which I tagged in z-shell/.github). v1.1.0 removes pinned Alpine package versions and improves rclone configuration file path resolution, fixing the 401 Unauthorized errors.
  2. Updated lib/checksum.txt to match the current lib/sh/install.sh, fixing the 'Check' workflow failures.

Copilot AI review requested due to automatic review settings May 16, 2026 14:36
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 16, 2026 •
edited
Loading

Deploying src with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9ff023a
Status: ✅  Deploy successful!
Preview URL: https://28929ec4.zi-src.pages.dev
Branch Preview URL: https://bug-fix-ci-failures-main.zi-src.pages.dev

View logs

Copilot AI reviewed May 16, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates CI-related references and refreshes the stored checksum used by repository validation workflows.

Changes:

  • Updated custom GitHub Actions for rclone sync and checksum commit steps to v1.1.0.
  • Refreshed lib/checksum.txt for the current lib/sh/install.sh checksum.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
lib/checksum.txt Updates the checksum entry for lib/sh/install.sh.
.github/workflows/rclone-action.yml Points the rclone workflow to the updated custom action SHA/tag.
.github/workflows/checksum.yml Points the checksum commit workflow to the updated custom action SHA/tag.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ss-o ss-o force-pushed the bug-fix-ci-failures-main branch 3 times, most recently from d122bfd to 9f9150e Compare May 16, 2026 16:14
@ss-o
fix(ci): resolve conflicts and complete lib to public migration
d38202e 
- Adopt latest changes from main
- Update rclone action to v1.1.1
- Complete migration of lib/ to public/
- Update README and workflow triggers
@ss-o ss-o force-pushed the bug-fix-ci-failures-main branch from 9f9150e to d38202e Compare May 16, 2026 16:22
@ss-o ss-o enabled auto-merge May 16, 2026 16:24
@ss-o ss-o disabled auto-merge May 19, 2026 02:54
@ss-o
fix(ci): complete lib→public migration; update installer scripts and …
e84ec7a 
…tests

- Update sync-init.sh with explicit --local/--remote/--checksum-url args
- Update check-linux.yml to pass explicit args to sync-init.sh
- Improve install.sh and install_zpmod.sh with better error handling
- Update checksums after public/ path changes
- Expand tests/installers.sh coverage
@ss-o ss-o mentioned this pull request May 19, 2026
Closed
@ss-o
Copy link
Copy Markdown
Member Author

ss-o commented May 23, 2026

Review notes — HOLD before merge

CI is all green and the core fixes are sound, but three things need addressing first.

1. Misleading title/description
Title says "fix rclone docker build and update checksums" but the actual scope includes a repo-wide lib/ → public/ rename and significant refactoring of install.sh / sync-init.sh. Description should reflect the real scope.

2. Breaking URL change — no migration notice
The rename changes all raw CDN URLs (raw.githubusercontent.com, jsDelivr, etc.) that external users may have pinned in their zshrc or scripts. The fallback in install.sh / sync-init.sh covers users running the new scripts, but anyone pointing at old URLs directly will break silently. Please add:

  • A CHANGELOG / PR note with old → new URL mapping
  • A deprecation timeline for lib/ paths
  • Consider a redirect stub or README note

3. Rclone scope expansion
local_path changed from "lib" to "." — this syncs the entire gh-pages branch to R2 instead of just shell scripts. Intentional? Please confirm explicitly.

What's good

  • sed -i portability fix ✓
  • mkdir -p hardening ✓
  • Fallback URLs in fetch_to_file() / _legacy_url() are a solid safety net ✓
  • Dependabot replacing Renovate ✓
  • SHA pins correct ✓

Once those three are addressed this is good to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ss-o