Merge main (v3.0.0) into develop#656
Open
github-actions[bot] wants to merge 13 commits intodevelopfrom
Open
Conversation
* feat: allow users to turn analytics on and off (v2.1.0) This PR adds a new property to the SearchAnalyticsConfig, which can be used to start with analytics enabled or disabled by default. Three new methods are added to the analytics object- two to turn analytics on/off, and one to get the current enabled status. J=WAT-5404 TEST=auto, manual Ran test site locally with debugging and buttons to turn analytics on and off, saw expected behavior. * Update various names to be in-line with pages code * Automated update to repo's documentation from github action * Add enableYextAnalytics function to window * drop unneeded parens --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
* More accessbilities fixes for autocomplete results Associate the visible label with the input via `label` + `htmlFor`, and wire `DropdownInput` with `inputId` and `aria-labelledby`. Change the instructions container from `hidden` to `sr-only`, so `aria-describedby` references content that is actually exposed to screen readers. J=WAT-5357 TEST=manual tested with voice over enabled on test-site * Update snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
* suppress error/warning spam, fix key errors etc * set ts output dir to dist * retry logic to WCAG
* fix linting; added optional region landmark semantics to FilterSearch * Automated update to repo's documentation from github action * chore: suppress error/warning spam, fix key errors etc (#642) * fix: point TypeScript output to dist directory (#644) * suppress error/warning spam, fix key errors etc * set ts output dir to dist * retry logic to WCAG * release: v2.1.2 * revert fieldset legend accessibility change * Automated update to repo's documentation from github action * optional toggle to show label on facet/static filter searchable sections; update locales * add group section semantics to filter search results when multiple sections --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
- make sure autocomplete option count is announced when the input is cleared too - detect all stale state value usages when using React.useState and fix to use a functional state update (eg setValue(value + 1) becomes setValue(prev => prev + 1))
) - current version has some accessibility issues that will be addressed by this upgrade - removed unnecessary @types/mapbox-gl import since mapbox-gl provides its own types - replace Mapbox-owned public types in search-ui-react with library-owned, version-stable interfaces - replace deprecated Mapbox aliases usage This PR also includes some improvements that I noticed when testing: - test-site pin popups not showing up - clean up the map listeners properly - memoizes the debounced function so it stays the same across renders unless milliseconds changes J=WAT-5461 TEST=auto,manual verified test-site still function as expected verified that locator functions as expected and that there is no longer any accessibility errors on live site
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge main (v3.0.0) into develop