fix: strict check for collapse item heading attribute#189
Open
fix: strict check for collapse item heading attribute#189
Conversation
Contributor
rivanuff
commented
Apr 1, 2026
There was a problem hiding this comment.
Pull request overview
This PR addresses block validation issues in the deprecated Collapse Item block by handling cases where the heading attribute is missing (null/undefined) more strictly during save.
Changes:
- Update
collapse-itemsave output to avoid rendering an invalid heading wrapper whenheadingis null/undefined. - Add a new deprecated
collapse-itemversion intended to prevent validation failures for content affected by an undefinedheading. - Minor JS simplification in the deprecated greetings inspector.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/deprecated/gemeenten/src/blocks/greetings/inspector.js | Simplifies state update using object property shorthand. |
| packages/deprecated/core/src/collapse/collapse-item/save.js | Treats heading null/undefined the same as an empty heading (no wrapper). |
| packages/deprecated/core/src/collapse/collapse-item/deprecated.js | Adds a deprecated block version to handle validation when heading is undefined. |
| package-lock.json | Updates lockfile entries (notably removing libc constraints for several optional native packages). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
41c0929 to
c056ae2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.