fix(windows): improve Node and npm detection for ACP agents#75
Open
Kwensiu wants to merge 2 commits intoxintaofei:mainfrom
Open
fix(windows): improve Node and npm detection for ACP agents#75Kwensiu wants to merge 2 commits intoxintaofei:mainfrom
Kwensiu wants to merge 2 commits intoxintaofei:mainfrom
Conversation
Use npm metadata to detect installed npx agent versions and broaden Windows Node path discovery so ACP status works reliably across nvm, fnm, and scoop setups.
Kwensiu
force-pushed
the
fix/windows-acp-node-detection
branch
from
91c2b32 to
581bb86
Compare
Owner
|
佬，你这个pr整体方向可以的，但是我发现有两个可疑点： 建议：只完善fnm的path发现，不要修改agent检测方式。 |
Author
|
请审批，修改后已经多轮 Review 确保符合项目规范，本地测试通过 
|
Owner
|
辛苦佬了，最好只修改fnm的path发现，不修改其它逻辑，只要把fnm的path环境变量补充进去就可以了，佬可以参照nvm的部分逻辑，可以提一个新的pr，当前pr改动影响不可控，等下个版本再合并佬的新pr。 |
Author
|
好，到时重新提一个 PR。如果佬清楚了，有需要的话也可以直接改了，不用等我慢慢磨，PR也可以直接关！ |
Owner
佬有时间的话可以帮忙弄一下，我本地没有fnm这些。。。 |
Author
打扰了，那我需要开新pr？还是直接force-push？我开了一个新分支，不过也可以移过来继续 那我待会直接迁移过来吧，不开新PR了 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #74
测试通过
