Skip to content

strip units instead of dequantifying #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keewis merged 3 commits into from
Feb 4, 2026
Merged

strip units instead of dequantifying #367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
63e1cc3
strip units instead of dequantifying
keewis Feb 4, 2026
233453e
Merge branch 'main' into fix-expects
keewis Feb 4, 2026
542c917
whats-new [skip-ci]
keewis Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/whats-new.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ What's new
--------------------
- Properly rename the coordinate units (:pull:`351`).
By `Justus Magin <https://github.com/keewis>`_.
- Don't rely on ``xarray``'s default behavior regarding ``attrs`` in :py:func:`pint_xarray.expects` (:issue:`360`, :pull:`367`)
By `Justus Magin <https://github.com/keewis>`_.

0.6.0 (31 Aug 2025)
-------------------
Expand Down
4 changes: 2 additions & 2 deletions pint_xarray/_expects.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import xarray as xr

from pint_xarray.accessors import get_registry
from pint_xarray.conversion import extract_units
from pint_xarray.conversion import extract_units, strip_units
from pint_xarray.itertools import zip_mappings

variable_parameters = (Parameter.VAR_POSITIONAL, Parameter.VAR_KEYWORD)
Expand Down Expand Up @@ -185,7 +185,7 @@ def wrapper(*args, **kwargs):
if isinstance(value, pint.Quantity):
params.arguments[name] = value.m_as(units)
elif isinstance(value, (xr.DataArray, xr.Dataset)):
params.arguments[name] = value.pint.to(units).pint.dequantify()
params.arguments[name] = strip_units(value.pint.to(units))
else:
raise TypeError(
f"Attempting to convert non-quantity {value} to {units}."
Expand Down
Loading