Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
dcherian
reviewed
Jul 3, 2025
dcherian
reviewed
Jul 3, 2025
dcherian
reviewed
Jul 3, 2025
Contributor
|
Also, +1 to automatic use in the plotting function, that was my initial intent! |
Contributor
Author
Contributor
|
Can we set the bounds on the cartopy crs since we have all the info? |
dcherian
reviewed
Sep 3, 2025
| func.__name__ == "wrapper" | ||
| and (kwargs.get("hue") or self._obj.ndim == 1) | ||
| ) | ||
| is_grid_plot = (func.__name__ in ["contour", "countourf", "pcolormsh"]) or ( |
Contributor
There was a problem hiding this comment.
Suggested change
| is_grid_plot = (func.__name__ in ["contour", "countourf", "pcolormsh"]) or ( | |
| is_grid_plot = (func.__name__ in ["contour", "countourf", "pcolormesh"]) or ( |
dcherian
reviewed
Sep 3, 2025
| kwargs = self._process_x_or_y(kwargs, "x", skip=kwargs.get("y")) | ||
| kwargs = self._process_x_or_y(kwargs, "y", skip=kwargs.get("x")) | ||
| if is_grid_plot and pyproj is not None: | ||
| from cartopy.mpl.geoaxes import GeoAxes |
Contributor
There was a problem hiding this comment.
let's check if cartopy is present with importlib.util.find_spec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This fixes #395.
crsaccessor to both the Dataset and DataArray accessors.