Skip to content

Harden tests#136

Merged
swissspidy merged 1 commit intomainfrom
fix/tests
Mar 19, 2026
Merged

Harden tests#136
swissspidy merged 1 commit intomainfrom
fix/tests

Conversation

@swissspidy
Copy link
Member

Follow-up to changes to the test suite in wp-cli/wp-cli-tests#274

Follow-up to changes to the test suite in wp-cli/wp-cli-tests#274
@github-actions
Copy link
Contributor

Hello! 👋

Thanks for opening this pull request! Please check out our contributing guidelines. We appreciate you taking the initiative to contribute to this project.

Contributing isn't limited to just code. We encourage you to contribute in the way that best fits your abilities, by writing tutorials, giving a demo at your local meetup, helping other users with their support questions, or revising our documentation.

Here are some useful Composer commands to get you started:

  • composer install: Install dependencies.
  • composer test: Run the full test suite.
  • composer phpcs: Check for code style violations.
  • composer phpcbf: Automatically fix code style violations.
  • composer phpunit: Run unit tests.
  • composer behat: Run behavior-driven tests.

To run a single Behat test, you can use the following command:

# Run all tests in a single file
composer behat features/some-feature.feature

# Run only a specific scenario (where 123 is the line number of the "Scenario:" title)
composer behat features/some-feature.feature:123

You can find a list of all available Behat steps in our handbook.

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request hardens the test suite by refining how a critical WordPress configuration constant is managed within the testing environment. It addresses potential instabilities in previous test setups by ensuring DISABLE_WP_CRON is consistently and correctly defined, thereby improving the reliability of WP-Cron related tests.

Highlights

  • Test Configuration Reliability: Updated the wp config set command in features/cron.feature to use a more robust anchor and placement for setting the DISABLE_WP_CRON constant, improving test stability.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves the cron feature tests by using a more reliable anchor in wp-config.php for setting the DISABLE_WP_CRON constant. This change makes the test setup more robust by using a standard comment block intended for custom values. The implementation is correct and I have no suggestions for improvement.

@codecov
Copy link

codecov bot commented Mar 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@swissspidy swissspidy marked this pull request as ready for review March 19, 2026 10:08
@swissspidy swissspidy requested a review from a team as a code owner March 19, 2026 10:08
Copilot AI review requested due to automatic review settings March 19, 2026 10:08
@swissspidy swissspidy merged commit 990a21f into main Mar 19, 2026
64 checks passed
@swissspidy swissspidy deleted the fix/tests branch March 19, 2026 10:08
@swissspidy swissspidy added this to the 2.3.5 milestone Mar 19, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the cron Behat feature setup to make the test environment configuration more robust, as a follow-up to recent wp-cli/wp-cli-tests suite changes.

Changes:

  • Adjusts the wp config set DISABLE_WP_CRON step to anchor on the standard wp-config “custom values” comment.
  • Ensures the constant is placed explicitly after that anchor (--placement=after) for deterministic insertion.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants