This repository was archived by the owner on Sep 15, 2025. It is now read-only.
Revert "Use the new appendURLString function in WordPressComRestApi"#729
Merged
crazytonyli merged 2 commits intotrunkfrom Feb 20, 2024
Merged
Revert "Use the new appendURLString function in WordPressComRestApi"#729crazytonyli merged 2 commits intotrunkfrom
crazytonyli merged 2 commits intotrunkfrom
Conversation
2 tasks
mokagio
approved these changes
Feb 20, 2024
Contributor
mokagio
left a comment
There was a problem hiding this comment.
Love the addition of a unit test 💪
Considering the commit b01de44 does break an use case in the app, and who knows what other strange "path" argument the app may pass, I'll revert the commit for now (to prevent it from being shipped in next release) and fix the illegal use case properly in separate PRs.
That seems very wise. I was pleased that the WordPress UI tests caught this issue. But I don't feel confident in the tests coverage to say that all issues related to this have been addressed 😞
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR reverts b01de44 due to an strange usage of
WordPressComRestApi.get(path:)function.WordPressKit-iOS/WordPressKit/ReaderPostServiceRemote.m
Lines 198 to 204 in ae8f83e
As you can see in the snippet above, a full URL (i.e.
https://public-api.wordpress.com/rest/v1.2/read/liked) is used as a path argument. IMO, this is an illegal use case (Gio has kindly create a fix for that in #727) which sends an correct HTTP requests.Considering the commit b01de44 does break an use case in the app, and who knows what other strange "path" argument the app may pass, I'll revert the commit for now (to prevent it from being shipped in next release) and fix the illegal use case properly in separate PRs.
Testing Details
See the added unit tests.
CHANGELOG.mdif necessary.