Show post types on home screens by crazytonyli · Pull Request #25233 · wordpress-mobile/WordPress-iOS

crazytonyli · 2026-02-10T07:55:58Z

Note

This PR will be merged after #25208.

Description

There are two main changes:

The custom posts list now looks similar to the Posts & Pages screens, using a tab view to filter by post status.
The custom post types can now be directly accessed from the home screens (Dashboard for .com sites, and "Blog Details" for self-hosted sites).

cpt-list.mov

dangermattic · 2026-02-10T07:56:31Z

	1 Warning
⚠️	This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

wpmobilebot · 2026-02-10T08:08:21Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Configuration	Release-Alpha
	Build Number	`30922`
	Version	`PR #25233`
	Bundle ID	`org.wordpress.alpha`
	Commit	`67d950e`
	Installation URL	0a0nc3tceiko8

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

wpmobilebot · 2026-02-10T08:08:33Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Configuration	Release-Alpha
	Build Number	`30922`
	Version	`PR #25233`
	Bundle ID	`com.jetpack.alpha`
	Commit	`67d950e`
	Installation URL	7mcf1cc64nbe8

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

wpmobilebot · 2026-02-10T08:54:13Z

🤖 Build Failure Analysis

This build has failures. Claude has analyzed them - check the build annotations for details.

kean · 2026-02-12T20:16:16Z

Modules/Sources/WordPressCore/ApiCache.swift

    }

+    // TODO:
+    // - Log errors to sentry: https://github.com/wordpress-mobile/WordPress-iOS/pull/25157#discussion_r2785458461


It's pretty easy to do with wpAssertionFailure and error included in user info. I did use these to monitor sync errors for posts.

kean · 2026-02-12T20:23:23Z

Modules/Sources/WordPressUI/Views/AdaptiveTabBarController.swift

 //        filterBarContainer.backgroundColor = .systemGroupedBackground // .secondarySystemGroupedBackground
        filterBarContainer.contentView.addSubview(filterBar)
-        filterBar.pinEdges(.top, to: filterBarContainer.safeAreaLayoutGuide, insets: UIEdgeInsets(.top, -filterBar.tabBarHeight))
+        filterBar.pinEdges(.top, to: filterBarContainer.safeAreaLayoutGuide, insets: UIEdgeInsets(.top, -AdaptiveTabBar.tabBarHeight))


It looks like it includes some unrelated changes. Does it need a rebase?

This changes are related (see #25233 (comment)). I extracted the value to a constant, to be reused in the CPT list view.

kean · 2026-02-12T20:25:06Z

WordPress/Classes/Utility/SiteStorage.swift

+import WordPressData
+
+@propertyWrapper
+struct SiteStorage<Value: Codable>: DynamicProperty {


This is clever. Does it work as an observable property?

I have added a SwiftUI preview to test this property wrapper. The preview code does not go through the .init(key:blog:) initialiser, because we don't have a blog id instance. But the core logic is tested.

kean · 2026-02-12T20:27:09Z

...ses/ViewRelated/Blog/Blog Dashboard/Cards/Quick Actions/DashboardQuickActionsViewModel.swift

-                )
+
+        if FeatureFlag.customPostTypes.enabled && blog.supportsCoreRESTAPI {
+            let pinned = SiteStorageAccess.pinnedPostTypes(for: TaggedManagedObjectID(blog))


I've tested this PR and a CPT I use for testing automatically appeared on the dashboard, which I'm not sure is what we want by default because the space is limited. I also don't see an option to configure it under "Personalization".

I took your suggestion here (p1770673465795309/1770627105.176769-slack-C04PWEZSYFL), maybe I misunderstood it?

I would probably simply inline these items in the top-level menu.

I didn't reuse the personalization because there is already a pin and unpin in the post types list. But I can look into unifying how they store values into UserDefaults.

I should've been clearer in that message. The suggestion was to add them directly in the "Content" menu in the site details as opposed to displaying all CPTs under "More Content", which it now does. As for the Dashboard, I'd probably keep it opt-in (you can add CPTs there if you want). The "quick actions" menu is intentionally short, so it doesn't overshadow the cards below.

Updated in 08f0c96

kean · 2026-02-12T20:28:05Z

WordPress/Classes/ViewRelated/CustomPostTypes/CustomPostTabView.swift

+import WordPressUI
+import WordPressData
+
+struct CustomPostTabView: View {


It's not clear if these changes are related to the PR, so I skipped reviewing them.

Yes, these changes are intentionally included in this PR. I don't want to create another chained PR, considering the changes are relatively small (from the filter design to tab design).

Gotcha, I'll review them as well tomorrow. Thank you.

kean · 2026-02-12T20:29:53Z

WordPress/Classes/ViewRelated/CustomPostTypes/Icons.swift

+
+private let mapping: [String: String] = [
+    // Commerce & Products
+    "products": "shippingbox",


It was already mentioned on other threads, but these icons don't fit well with the menus, and should ideally be updated to use Gutenberg icons.

In the case of my site, the two icons look different. I'm not sure if there are default icons though.

I have looked into reusing Gutenberg icons and will share some screenshots later.

The only solution for matching wp-admin icons is using dashicons. As discussed in p1769760142081339-slack-C06S1QS55K9, I don't think we want to use them in the app.

At the moment, the CPT icons (set by plugin author) are mapped to SF symbols. We can expand the mapping as we go. But I imagine we don't have many choices if we map the icons to Gutenberg icons, which is a much smaller set than SF symbols.

Nonetheless, I think we can probably address this in a separate PR.

Otherwise the user won't be able to unpin post types.

sonarqubecloud · 2026-02-13T08:42:24Z

Quality Gate passed

Issues
9 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

crazytonyli added this to the 26.7 milestone Feb 10, 2026

crazytonyli requested a review from kean February 10, 2026 07:55

crazytonyli added the Custom Post Types label Feb 10, 2026

kean reviewed Feb 12, 2026

View reviewed changes

crazytonyli mentioned this pull request Feb 13, 2026

Support editing custom posts #25208

Open

crazytonyli added 7 commits February 13, 2026 16:54

Show error messages on the custom post types screens

49f80c1

Align custom posts UI with Posts & Pages

c6ea01c

Show pinned post types on My Site

47a45aa

Automatically pin post types

d116587

Change "More Content" to "More"

7c1471f

Add "Send Feedback" button to the post list

815a298

Add a Preview block to test SiteStorage

10bc524

crazytonyli force-pushed the custom-post-types-remove-task branch from 9704712 to 10bc524 Compare February 13, 2026 03:55

crazytonyli requested a review from kean February 13, 2026 03:55

crazytonyli added 2 commits February 13, 2026 21:33

Do not show post types on the Blog Dashboard

08f0c96

Always show the viewing all custom post types list

67d950e

Otherwise the user won't be able to unpin post types.

Conversation

crazytonyli commented Feb 10, 2026

Description

Uh oh!

dangermattic commented Feb 10, 2026

Uh oh!

wpmobilebot commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 Build Failure Analysis

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kean Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Feb 13, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

wpmobilebot commented Feb 10, 2026 •

edited

Loading

wpmobilebot commented Feb 10, 2026 •

edited

Loading

wpmobilebot commented Feb 10, 2026 •

edited

Loading

kean Feb 12, 2026 •

edited

Loading