Skip to content

[RN78][public] TextField - no default preset shown in the screen#3946

Merged
M-i-k-e-l merged 2 commits intov9from
fix/textfield-default-preset
Mar 9, 2026
Merged

[RN78][public] TextField - no default preset shown in the screen#3946
M-i-k-e-l merged 2 commits intov9from
fix/textfield-default-preset

Conversation

@MIchaelZablianov
Copy link
Collaborator

@MIchaelZablianov MIchaelZablianov commented Mar 9, 2026

Description

After investigating the issue - 4965, it came out that the issue is only in the demo screen, due to how Switch (SegmentedControl) is implemented.

  • Set the default TextField preset in the demo screen from undefined to TextField.presets.UNDERLINE so the demo launches with the underline style by default.

Changelog

  • TextField - Set default preset to UNDERLINE in demo screen

Additional info

ticket 4965

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2026

✅ PR Description Validation Passed

All required sections are properly filled out:

  • Description
  • Changelog
  • Additional info

Your PR is good for review! 🚀


This validation ensures all sections from the PR template are properly filled.

@MIchaelZablianov MIchaelZablianov requested review from M-i-k-e-l and removed request for lidord-wix March 9, 2026 11:47
@MIchaelZablianov MIchaelZablianov changed the title [TextField] - Set default preset to UNDERLINE in demo screen [RN78][public] TextField - no default preset shown in the screen Mar 9, 2026
Copy link
Collaborator

@M-i-k-e-l M-i-k-e-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Looking at this again I found this line:

TextField.defaultProps = {preset: TextField.presets.UNDERLINE, ...TextField.defaultProps};

Which when removed gives the same outcome in master.
So this solution seems valid, please remove the relevant line(s).

Also, please remove the [, ] in the changelog

@M-i-k-e-l M-i-k-e-l merged commit 52e3971 into v9 Mar 9, 2026
3 checks passed
@M-i-k-e-l M-i-k-e-l deleted the fix/textfield-default-preset branch March 9, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants