fix: [CI-19914] Forward fix final: adding strict FIPS-safe fallback#127
Open
ebtasam-faridy wants to merge 2 commits intowings-software:masterfrom
Open
fix: [CI-19914] Forward fix final: adding strict FIPS-safe fallback#127ebtasam-faridy wants to merge 2 commits intowings-software:masterfrom
ebtasam-faridy wants to merge 2 commits intowings-software:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added fallback in case of ssh key-scan failure
Replaced direct ssh-keyscan ... 2>/dev/null with captured stderr:
introduces KEYSCAN_ERR_FILE
runs keyscan under set +e and captures SSH_KEYSCAN_EXIT
Adds conditional command selection:
if keyscan succeeds -> default GIT_SSH_COMMAND (unchanged from old)
else -> fallback GIT_SSH_COMMAND:
StrictHostKeyChecking=accept-new
KexAlgorithms=ecdh-sha2-nistp256,diffie-hellman-group14-sha256