WIP: AR support

[mariobuikhuizen]

No description provided.

[maartenbreddels]

Looking good, however for some reason it seems the center of the box seems to be placed at the floor, I will check that out. 2 small changes requested.

[maartenbreddels]

Suggested change

	renderer.setAnimationLoop(() => null);
	renderer.setAnimationLoop(null);

Otherwise we still render continuous after stopping.

[maartenbreddels]

Suggested change

	this.model.set("box_center", [0.5, 0.5,-3]);
	this.model.set("box_center", [0.5, 0.5, -3]);

[maartenbreddels]

Sharing the demo:

ipyvolume-ar-scatter-no-audio.mp4

It seems also that the floor is moving wrt the scene btw.

[maartenbreddels]

To reproduce the klein bottle:

fig = ipv.figure()
ipv.examples.klein_bottle()
ipv.save("ar.html", devmode=True)

To make sure we pick up the right ipyvolume from this branch:

$ (cd js; npm run watch:dev) 
$ ln ~/src/ipyvolume/js/dist/index.js.map index.js.map 
$ ln ~/src/ipyvolume/js/dist/index.js ipyvolume.js
$ python -m ipyvolume.server

Open from your phone:: https:///ar.html (ignore the self signed certificate and continue)
click the AR button (only visible when your phone supports it).

@mariobuikhuizen can you share the link where all supported devices are listed?

[mariobuikhuizen]

Supported devices: https://developers.google.com/ar/devices.

For iOS https://labs.mozilla.org/projects/webxr-viewer/ can be used.

[mariobuikhuizen]

@maartenbreddels how can I get your example running? Where does the python code go?

[maartenbreddels]

just execute it from anywhere, in a script, or from the REPL, since we save it to HTML, no jupyter environment is needed.

[mariobuikhuizen]

Ah, missed the saving to HTML.

[smith-kyle]

I'm a little late to the party, but I noticed you all aren't using a notebook review tool and wanted to invite you to review this pull request with GitNotebooks: https://gitnotebooks.com/widgetti/ipyvolume/pull/397

It lets you do things like comment on rendered markdown and code cells, so might be an easy win for your PR reviews.