Make dummyURL from the basic URL parser with a special scheme#269
Make dummyURL from the basic URL parser with a special scheme#269sisidovski merged 4 commits intowhatwg:mainfrom
Conversation
|
@annevk Not sure if this kind of simple change address the issue. Could you give some advice? Thank you! |
annevk
left a comment
annevk
left a comment
There was a problem hiding this comment.
Modulo a couple of nits I think this is the right approach, yeah. This is also pretty much how WebKit handles this.
…orrect basic URL parser invocation
|
Updated based on your suggestions, thank you! |
spec.bs
Outdated
|
|
||
| 1. If |value| is the empty string, return |value|. | ||
| 1. Let |dummyURL| be a new [=URL record=]. | ||
| 1. Let |dummyURL| be the result of [=create a dummy URL=]. |
There was a problem hiding this comment.
You want "creating" not "create" here (and below) to get a proper sentence (you don't have to change the <dfn> for that, as I mentioned Bikeshed takes care of making that work).
|
@sisidovski when merging this, please take care to follow https://github.com/whatwg/meta/blob/main/COMMITTING.md (in particular the Squash and merge section). I noticed this went wrong a few times for this repository. Feel free to reach out on https://whatwg.org/chat if you have questions or ask @domenic internally. |
2 participants
Based on the discussion in #252.
We should not use URL records directly to canonicalize components, we should specify a special scheme as a default scheme. When we create a dummy URL, it should be created from the basic URL parser. This is not ideal but this can be achieved by creating a dummy URL with this fixed URL string.
Preview | Diff