feat(auth): include token header for catalog search#1198
Draft
apetersson wants to merge 1 commit intowger-project:masterfrom
Draft
feat(auth): include token header for catalog search#1198apetersson wants to merge 1 commit intowger-project:masterfrom
apetersson wants to merge 1 commit intowger-project:masterfrom
Conversation
Member
|
Hi! Would you then block all access to API endpoints that don't send a token in the header? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sends auth headers for catalog search API calls that will be auth-required server-side.
note: This PR has been created with LLM assistance (codex). The change is not very big though, but necessary for my self-hosted resource protection to prevent DOS.
What changed
Authorizationheaders (via existingmakeHeader()) to:Why
wgerPR:feat(api): require auth for public catalog endpointsCompatibility
Inter-dependency
I double-checked
wger-flutterand for current app flow this should not break.What I verified:
loggedIn:loggedOutshows login screen, not exercise/nutrition screens.WgerBaseProvider.fetch(...), which always sends auth:language,exerciseinfo,exercise/searchin exercises.dartingredientinfoin nutrition.dartConclusion:
wger-flutter.