Add Support for Express 5 and Remove Support for Express 4#77
Open
Megapixel99 wants to merge 7 commits intomainfrom
Open
Add Support for Express 5 and Remove Support for Express 4#77Megapixel99 wants to merge 7 commits intomainfrom
Megapixel99 wants to merge 7 commits intomainfrom
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Collaborator
Author
|
This PR is dependent on |
3759e8c to
ef0a065
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Despite the initial hope of this being a small pull request, there were a lot of required changes to improve the readability of the code and support Express 5. I tried to comment the code as best I could but if something looks off, please add a comment in the PR.
Breaking Changes:
Major Changes:
lib/generate-doc.jsexpressto the latest versionexpressa peer dependencyrouterto feat: add getRoutes method to list registered routes pillarjs/router#174 (so we can accessgetRoutes())Minor Changes:
_moreRoutes.jsexternal route #74lib/validate.jswith code found here: fix: ensure req.query is writable vercel/next.js#81573 (comment) so we can coercereq.queryandreq.params(req.queryandreq.paramsare read only in Express 5 by default)