feat: prioritize inferring property type from value#335
Open
yangmingshan wants to merge 1 commit intowechat-miniprogram:masterfrom
Open
feat: prioritize inferring property type from value#335yangmingshan wants to merge 1 commit intowechat-miniprogram:masterfrom
yangmingshan wants to merge 1 commit intowechat-miniprogram:masterfrom
Conversation
Contributor
Contributor
Author
|
@lv-z-l 我没有在说你的修改有问题。我是在解释为什么我要改为: type FullPropertyToData<T extends AllFullProperty> = T['type'] extends null | BooleanConstructor ? ValueType<T['type']> : unknown extends T['value'] ? ValueType<T['type']> : T['value']而非: type FullPropertyToData<T extends AllFullProperty> = T['type'] extends null ? ValueType<T['type']> : unknown extends T['value'] ? ValueType<T['type']> : T['value']注意二者 |
Contributor
|
get |
Contributor
Author
|
@SgLy 大佬麻烦看一下 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

参考:#332 (comment)
boolean类型不能优先从 value 推导,否则推导出来的类型是true或者false,而非boolean