Conversation
1857737 to
ff7c894
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hidden by default for now.
See https://support.delta.chat/t/run-webxdc-apps-in-the-browser-we-added-try-it-button-to-the-app-store/4445?u=wofwca.
I am committed to maintaining the https://webxdc-try-it.xyz site
for at least 2 years.
However, if this feature is liked it would be really nice
to do the deployment on some more "official" servers,
such as webxdc.org itself.
Luckily, the deployment isn't that hard.
See https://github.com/DavidSM10/web-app-runner?tab=readme-ov-file#how-set-it-up-online.
The reason we can't simply always show this button
is because the the
/appspage is used by Delta Chat for Androidas the app picker ("Add Attachment"), where such a button doesn't make sense.
Also maybe Delta Touch does the same.
I suggest to act as follows:
add a query (search) param
hideTryItButtonto the app picker's URL,so that the website's JS can read it and disable the "Try It" button.
from the previous steps.
so that you don't have to hope that I don't get hit by a bus.
CC @davidsm10