rewrite class components to functional components#8165
Open
sujalgoel wants to merge 8 commits intowebpack:mainfrom
Open
rewrite class components to functional components#8165sujalgoel wants to merge 8 commits intowebpack:mainfrom
sujalgoel wants to merge 8 commits intowebpack:mainfrom
Conversation
Converts all 7 class components to functional components, closes webpack#8161. Also fixes a bug in SidebarMobile where touchmove listeners were attached via React's JSX event system which defaults to passive, blocking preventDefault() during swipe gestures. Moved those handlers to native addEventListener with { passive: false }. Adds tests for Dropdown, SidebarMobile, and Support per issue discussion. Also updates jest.config.mjs to handle .mjs transforms and adds a file mock for png/jpg assets.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts all 7 class components to functional components, closes #8161.
Also fixes a bug in
SidebarMobilewheretouchmovelisteners were attached via React's JSX event system, which defaults to passive, sopreventDefault()was being silently blocked during swipe gestures. Moved those handlers to nativeaddEventListenerwith{ passive: false }.Adds tests for
Dropdown,SidebarMobile, andSupportper the discussion in the issue. Also updatesjest.config.mjsto handle.mjstransforms and adds a file mock for png/jpg assets.components changed
SidebarMobile- touchmove passive listener fix + conversionCube- continuous animation and hover spinDropdown- keyboard navigation, Escape to close, click outside to closeTextRotater- rotation with setTimeout/requestAnimationFrameSupport- IntersectionObserver for lazy avatar loadingSplashViz- render-only, straightforward conversionConfiguration/components(Details) - popover open/closetest plan
npm testpasses (83 tests)