feat(WebexMember): split component into space members and meeting participant#772
Open
thescripted wants to merge 2 commits intowebex:masterfrom
Open
feat(WebexMember): split component into space members and meeting participant#772thescripted wants to merge 2 commits intowebex:masterfrom
thescripted wants to merge 2 commits intowebex:masterfrom
Conversation
473bc67 to
78b320f
Compare
src/components/WebexMeetingParticipant/WebexMeetingParticipant.jsx
Outdated
Show resolved
Hide resolved
src/components/WebexMeetingParticipant/WebexMeetingParticipant.jsx
Outdated
Show resolved
Hide resolved
f1a0714 to
6991e6e
Compare
6991e6e to
6827327
Compare
Contributor
This seems to introduce some code duplication, can this be avoided? For example, leaving the generic WebexMember component as-is, and introducing two additional components:
These components would just use WebexMember with a hardcoded destination type, avoiding of duplication of js code and css: function WebexSpaceMember(...) {
return <WebexMember destinationType="ROOM" ... />;
}Maybe the same could be done for the roster. I would suggest using the names WebexSpaceRoster and WebexMeetingRoster, so that the difference is clear: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separate
WebexMemberintoWebexMemberfor spaces andWebexMeetingParticipantfor meetingsSeparate
WebexMemberRosterintoWebexMemberRosterfor spaces andWebexMeetingRosterfor meetingsSPARK-308491
SPARK-308492