This repository was archived by the owner on Aug 1, 2022. It is now read-only.
Open
Conversation
trevismd
suggested changes
Mar 24, 2021
trevismd
left a comment
trevismd
left a comment
There was a problem hiding this comment.
A bit late, but some suggestions, in case the author finds the time to review/merge PRs.
I'm not a maintainer of this repository, though.
| pval, | ||
| ) | ||
| elif test == 'anova': | ||
| u_stat, pval = stats.f_oneway( |
There was a problem hiding this comment.
For clarity in the code, and accurate reporting below, I'd change u_stat to f_stat.
| u_stat, | ||
| pval, | ||
| ) | ||
| elif test == 'anova': |
There was a problem hiding this comment.
Most tests (not t-test_something) are capitalized, so I'd suggest Anova for consistency
| valid_list = ['t-test_ind', 't-test_welch', 't-test_paired', | ||
| 'Mann-Whitney', 'Mann-Whitney-gt', 'Mann-Whitney-ls', | ||
| 'Levene', 'Wilcoxon', 'Kruskal'] | ||
| 'Levene', 'Wilcoxon', 'Kruskal', "anova"] |
Comment on lines
+30
to
+31
| EDIT 16.11.2020 - Veronika Brumovska | ||
| - implementing ANOVA (line 84) |
There was a problem hiding this comment.
I don't think this was ever done in this repo, but it would be great to be logged.
I wouldn't put that here though. Maybe we could suggest a changelog or acknowledgement file dedicated to contributions ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added Anova test.