Replace Utils::toHex() with direct conversion.

[pash7ka]

If an argument to a contract method is a string which can be converted to number (like "1"), Utils::toHex() does this conversion. Also if sting starts with '0x' it will be stripped, which may be not expected behaviour.

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@1fb7762). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master      #61   +/-   ##
=========================================
  Coverage          ?   88.24%           
  Complexity        ?      661           
=========================================
  Files             ?       47           
  Lines             ?     1455           
  Branches          ?        0           
=========================================
  Hits              ?     1284           
  Misses            ?      171           
  Partials          ?        0

Impacted Files	Coverage Δ	Complexity Δ
src/Contracts/Types/Str.php	100% <100%> (ø)	7 <0> (?)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fb7762...15b1103. Read the comment docs.

[sc0Vu]

Hi @pash7ka
If you pass 0x prefixed string, it will strip the zero.
I think it might not be expected behavior.
Maybe it better to change behavior in Util::toHex.

[pash7ka]

Hi @sc0Vu
With my fix 0x prefix will stay intact. One example of such string is tx hash, which somebody may want to store in the contract as a string.
I agree, that fixing this in Util::toHex would be preffered, but to do it properly we may need to add additional parameter to Util::toHex with the type of input. It's a major rewrite of this function, which i decided to leave up to you.