Implementation of Contract::getEventLogs() and improved general comments and error messages#196
Open
Nanolucas wants to merge 22 commits intoweb3p:masterfrom
Open
Implementation of Contract::getEventLogs() and improved general comments and error messages#196Nanolucas wants to merge 22 commits intoweb3p:masterfrom
Nanolucas wants to merge 22 commits intoweb3p:masterfrom
Conversation
Attempting to make some of the comments and errors easier to understand and clearer in what it does / what is required
A working, improved and deciphered version of the function alluded to in web3p#93
Codecov Report
@@ Coverage Diff @@
## master #196 +/- ##
============================================
- Coverage 87.39% 85.29% -2.10%
- Complexity 729 750 +21
============================================
Files 47 47
Lines 1594 1632 +38
============================================
- Hits 1393 1392 -1
- Misses 201 240 +39
Continue to review full report at Codecov.
|
also improve general comments throughout function
niccolopetti
approved these changes
Mar 22, 2021
Author
|
Completed implementation of Contract::getEventLogs() functionality, as initially described/requested in #93 |
Nanolucas
changed the title
momocode-de
reviewed
Apr 17, 2021
momocode-de
reviewed
Apr 17, 2021
|
Can this be merged into PHP 8 branch? |
| $decodedData = array_combine($eventParameterNames, $this->ethabi->decodeParameters($eventParameterTypes, $object->data)); | ||
|
|
||
| //decode the indexed parameter data | ||
| for ($i = 0; $i < $numEventIndexedParameterNames; $i++) { |
There was a problem hiding this comment.
$numEventIndexedParameterNames is not defined anywhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated comments and error messages to improve clarity and consistency