Skip to content

refactor(controller): revert to exit() instead of connect window::destroyed → controller::exit, stop card event monitor thread immediately on cancel and on critical failure#201

Draft
mrts wants to merge 1 commit intomainfrom
fix-macos-qt5-tests
Draft

refactor(controller): revert to exit() instead of connect window::destroyed → controller::exit, stop card event monitor thread immediately on cancel and on critical failure#201
mrts wants to merge 1 commit intomainfrom
fix-macos-qt5-tests

Conversation

@mrts
Copy link
Member

@mrts mrts commented Jun 8, 2022

WE2-672

@mrts mrts added this to the v2.1.0 milestone Jun 8, 2022
@mrts mrts force-pushed the fix-macos-qt5-tests branch 7 times, most recently from 5d0e619 to e32a24a Compare June 10, 2022 19:56
@mrts mrts changed the title refactor(threads): disconnect threads immediately on cancel and on confirm completed refactor(threads): stop card event monitor thread immediately on cancel and on critical failure Jun 10, 2022
@mrts mrts force-pushed the fix-macos-qt5-tests branch from e32a24a to 1c975b1 Compare June 10, 2022 20:01
@mrts
refactor(controller): revert to exit() instead of connect dialog quit…
c64653b 
… to exit, stop card event monitor thread immediately on cancel and on critical failure

WE2-672

Signed-off-by: Mart Somermaa <mrts@users.noreply.github.com>
@mrts mrts force-pushed the fix-macos-qt5-tests branch from 1c975b1 to c64653b Compare June 13, 2022 11:10
@mrts mrts changed the title refactor(threads): stop card event monitor thread immediately on cancel and on critical failure refactor(controller): revert to exit() instead of connect(window, &WebEidUI::destroyed, this, &Controller::exit), stop card event monitor thread immediately on cancel and on critical failure Jun 13, 2022
@mrts mrts changed the title refactor(controller): revert to exit() instead of connect(window, &WebEidUI::destroyed, this, &Controller::exit), stop card event monitor thread immediately on cancel and on critical failure refactor(controller): revert to exit() instead of connect window::destroyed → controller::exit, stop card event monitor thread immediately on cancel and on critical failure Jun 13, 2022
@mrts mrts modified the milestones: v2.1.0, vNext Jul 25, 2022
@mrts mrts modified the milestones: v2.2.0, vNext Dec 27, 2022
@mrts mrts removed this from the vNext milestone Feb 20, 2023
@mrts mrts marked this pull request as draft September 15, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mrts