Open
Conversation
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts the previously added workaround that suppressed an authlib.jose deprecation warning by removing the compatibility module and its side-effect import, now that the upstream warning is reported as removed.
Changes:
- Deleted
weaviate/_authlib_compat.py(warning suppression shim). - Removed the side-effect import of
_authlib_compatfromweaviate/__init__.py. - Removed the related “remove-on-authlib-2.0” note from
setup.cfg.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
weaviate/_authlib_compat.py |
Removes the local warning-filter module entirely. |
weaviate/__init__.py |
Drops the import that triggered the warning suppression side effect. |
setup.cfg |
Cleans up dependency comment tied to the removed shim. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -37,8 +37,6 @@ install_requires = | |||
| httpx>=0.26.0,<0.29.0 | |||
| validators>=0.34.0,<1.0.0 | |||
| authlib>=1.6.7,<2.0.0 | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #2026
authlib removed the warning: authlib/authlib#880 lets merge this revert after 1.7.1 has been released