Set request's initiator and destination to empty string in cache.addA…#1822
Merged
yoshisatoyanagisawa merged 2 commits intow3c:mainfrom Apr 9, 2026
Merged
Conversation
…ll() (w3c#1718) As pointed out in w3c#1718, "fetch" is not a valid value for a request's initiator, and "subresource" is not a valid destination in the Fetch specification. Following the discussion in the issue, cache.addAll() should function the same as if a script ran fetch() directly. Therefore, both initiator and destination should be set to the empty string. This updates the Cache/addAll algorithm steps in the specification. Fixes w3c#1718
Collaborator
Author
|
@wanderview Will you review this? |
wanderview
requested changes
Apr 8, 2026
Remove setting initiator and destination to empty string.
wanderview
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As pointed out in #1718, "fetch" is not a valid value for a request's initiator, and "subresource" is not a valid destination in the Fetch specification.
Following the discussion in the issue,
cache.addAll()should function the same as if a script ranfetch()directly. Therefore, both initiator and destination should be set to the empty string.Fixes #1718
Preview | Diff