chore: Allow magic value comparisons in test files#6
Open
Jan-Frederik Schmidt (g3n35i5) wants to merge 1 commit intorelease/2.Xfrom
Open
chore: Allow magic value comparisons in test files#6Jan-Frederik Schmidt (g3n35i5) wants to merge 1 commit intorelease/2.Xfrom
Jan-Frederik Schmidt (g3n35i5) wants to merge 1 commit intorelease/2.Xfrom
Conversation
Jan-Frederik Schmidt (g3n35i5)
requested a review
from Philipp Caspers (philipp-caspers)
as a code owner
Disable Ruff rule PLR2004 for test files to allow magic value comparisons, which are standard practice in test assertions (e.g., `assert len(list) == 5`). This rule is overly restrictive for test code where hard-coded expected values are common and expected.
Jan-Frederik Schmidt (g3n35i5)
force-pushed
the
chore/disable-ruff-rule-tests
branch
from
2d4528e to
c69dd06
Compare
Jan-Frederik Schmidt (g3n35i5)
changed the title
Jan-Frederik Schmidt (g3n35i5)
requested a review
from Michael Barulin (MichaelBarulin)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable Ruff rule PLR2004 for test files to allow magic value
comparisons, which are standard practice in test assertions
(e.g., "assert len(list) == 5").
This rule is overly restrictive for test code where hard-coded
expected values are common and expected.