Skip to content

Conversation

@vmg-dev
Copy link
Owner

@vmg-dev vmg-dev commented Feb 12, 2026

Summary

  • add dedicated setup guides for macOS and Linux
  • document how to choose --platform for conversions/tests
  • turn integration tests into image-parameterized tests
  • run integration tests in CI as a distro matrix (Alpine, Debian, Ubuntu, Fedora, Arch)

Validation

  • bun run test
  • bun run typecheck
  • bun run build
  • bun run test:integration (busybox)
  • bun run test:integration with Alpine/Debian/Ubuntu/Fedora images on arm64 host
  • bun run e2e:smoke

Copy link
Owner Author

@vmg-dev vmg-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed locally with gh CLI. Found one issue: in test/integration/oci2gondolin.integration.test.ts, assertProbeMissingFromBaseImage uses original GONDOLIN_GUEST_DIR when set, so the "base image" probe can run against custom assets and fail incorrectly. Consider unsetting GONDOLIN_GUEST_DIR for that check, then restoring it in finally.

@vmg-dev vmg-dev merged commit d5ee127 into main Feb 12, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant