Skip to content

Add configurable Claude model via top-level model config key#80

Merged
vm-mishchenko merged 1 commit into
mainfrom
260514-spec-configurable-claude-model
May 14, 2026
Merged

Add configurable Claude model via top-level model config key#80
vm-mishchenko merged 1 commit into
mainfrom
260514-spec-configurable-claude-model

Conversation

@vm-mishchenko
Copy link
Copy Markdown
Owner

Summary

  • Adds a top-level model: key to draft config that passes --model <value> to every claude invocation via Runner
  • Callers that already supply --model in extra_args (e.g. _live_status.py) are not overridden — prevents double-injection
  • validate_config rejects non-string and blank model: values with a clear error at startup

Test plan

  • New tests in tests/pipeline/test_runner.py cover: model injection, omission when unset, no double-inject when extra_args already has --model, whitespace normalisation, and coexistence with other extra_args
  • New tests in tests/draft/test_config.py cover: valid string accepted, absent key accepted, blank/non-string values rejected, step validation still runs after a valid model:, and merge behaviour (project overrides global)
  • All existing tests pass without modification

Allow users to specify the Claude model draft passes to `claude --model`
through a top-level `model` key in global or project config. Project
config wins over global when both are present. When absent, draft omits
`--model` entirely and lets the claude CLI pick its own default.

The setting applies uniformly across all commands (create, continue,
babysit, fix-pr). Callers that already supply `--model` via `extra_args`
take precedence, preventing double-injection.
@vm-mishchenko vm-mishchenko marked this pull request as ready for review May 14, 2026 23:07
@vm-mishchenko vm-mishchenko merged commit 6e9c153 into main May 14, 2026
1 check passed
@vm-mishchenko vm-mishchenko deleted the 260514-spec-configurable-claude-model branch May 14, 2026 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant