feat: add section icons to nav buttons and contextual dropdown label#53
Merged
darcyclarke merged 1 commit intovltpkg:mainfrom Mar 5, 2026
Merged
Conversation
- Add associative icons to main section navigation buttons: - Package Managers → Package icon - Task Runners → StopWatch icon - Registries → Database icon (new custom icon) - Rename mobile 'Fixture' dropdown to 'Registries' when viewing the registries section (contextual label via baseRoute prop) New file: app/src/components/icons/database.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two UI improvements to the benchmarks app navigation:
1. Section Icons on Navigation Buttons
Each main section button now has an associative icon for better visual recognition:
Icons are sized at
size-4and render inline before the label text.2. Contextual Dropdown Label for Registries
The mobile variation dropdown (previously hardcoded as "Fixture") now shows a context-appropriate label:
/package-managers/*/task-runners/*/registries/*This is implemented via an optional
baseRouteprop onVariationDropdown, with a fallback lookup map.Files Changed
app/src/components/icons/database.tsxapp/src/components/icons/index.tsapp/src/components/header.tsxapp/src/components/variation-dropdown.tsxBuild: ✅
tsc -b && vite buildcleanFormat: ✅ Prettier clean