Skip to content

Default resourceTrackingMethod annotation #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sector2000 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Default resourceTrackingMethod annotation #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a0a04bc
Update README template to include additional notable changes
sector2000 Feb 17, 2026
929625d
Now resourceTrackingMethod defaults to "annotation"
sector2000 Feb 17, 2026
51a9d8c
Update README template to include additional notable changes
sector2000 Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ This chart is used to set up the basic building blocks in [Validated Patterns](h

### Notable changes

* v0.9.44: Default value of `resourceTrackingMethod` is now `annotation`
* v0.9.43: Add support to `env`, `volumes` and `volumeMounts` in repository server
* v0.9.38: Ensure sharedValueFiles and extraValueFiles are always prefixed with $patternref
* v0.9.37: Use global.patternDelete value set by patterns operator when patterns are deleted
* v0.9.32: Add labels and annotations to operatorgroups when included in namespaces
Expand Down Expand Up @@ -44,7 +46,7 @@ This chart is used to set up the basic building blocks in [Validated Patterns](h
| clusterGroup.argoCD.resourceHealthChecks[1].check | string | `"local health_status = {}\n\nhealth_status.status = \"Progressing\"\nhealth_status.message = \"Waiting for InferenceService to report status...\"\n\nif obj.status ~= nil then\n\n local progressing = false\n local degraded = false\n local status_false = 0\n local status_unknown = 0\n local msg = \"\"\n\n if obj.status.modelStatus ~= nil then\n if obj.status.modelStatus.transitionStatus ~= \"UpToDate\" then\n if obj.status.modelStatus.transitionStatus == \"InProgress\" then\n progressing = true\n else\n degraded = true\n end\n msg = msg .. \"0: transitionStatus | \" .. obj.status.modelStatus.transitionStatus\n end\n end\n\n if obj.status.conditions ~= nil then\n for i, condition in pairs(obj.status.conditions) do\n\n -- A condition is healthy if its status is True.\n -- However, for the 'Stopped' condition, a 'False' status is the healthy state.\n local is_healthy_condition = (condition.status == \"True\")\n if condition.type == \"Stopped\" then\n is_healthy_condition = (condition.status == \"False\")\n end\n\n if not is_healthy_condition then\n -- This condition represents a problem, so update counters and the message.\n if condition.status == \"Unknown\" then\n status_unknown = status_unknown + 1\n else\n status_false = status_false + 1\n end\n\n msg = msg .. \" | \" .. i .. \": \" .. condition.type .. \" | \" .. condition.status\n if condition.reason ~= nil and condition.reason ~= \"\" then\n msg = msg .. \" | \" .. condition.reason\n end\n if condition.message ~= nil and condition.message ~= \"\" then\n msg = msg .. \" | \" .. condition.message\n end\n end\n\n end\n\n if progressing == false and degraded == false and status_unknown == 0 and status_false == 0 then\n health_status.status = \"Healthy\"\n msg = \"InferenceService is healthy.\"\n elseif degraded == false and status_unknown >= 0 then\n health_status.status = \"Progressing\"\n else\n health_status.status = \"Degraded\"\n end\n\n health_status.message = msg\n end\nend\n\nreturn health_status\n"` | |
| clusterGroup.argoCD.resourceHealthChecks[1].group | string | `"serving.kserve.io"` | |
| clusterGroup.argoCD.resourceHealthChecks[1].kind | string | `"InferenceService"` | |
| clusterGroup.argoCD.resourceTrackingMethod | string | `"label"` | |
| clusterGroup.argoCD.resourceTrackingMethod | string | `"annotation"` | |
| clusterGroup.argoCD.volumeMounts | list | `[]` | |
| clusterGroup.argoCD.volumes | list | `[]` | |
| clusterGroup.extraObjects | object | `{}` | |
Expand Down
2 changes: 2 additions & 0 deletions README.md.gotmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ This chart is used to set up the basic building blocks in [Validated Patterns](h

### Notable changes

* v0.9.44: Default value of `resourceTrackingMethod` is now `annotation`
* v0.9.43: Add support to `env`, `volumes` and `volumeMounts` in repository server
* v0.9.38: Ensure sharedValueFiles and extraValueFiles are always prefixed with $patternref
* v0.9.37: Use global.patternDelete value set by patterns operator when patterns are deleted
* v0.9.32: Add labels and annotations to operatorgroups when included in namespaces
Expand Down
2 changes: 1 addition & 1 deletion values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ clusterGroup:
volumeMounts: []
configManagementPlugins: []
# resource tracking can be set to annotation, label, or annotation+label
resourceTrackingMethod: label
resourceTrackingMethod: annotation
resourceHealthChecks:
# Adding health checks to argocd to prevent pvc resources
# that aren't bound state from blocking deployments
Expand Down