Skip to content

Conversation

@oech3
Copy link
Contributor

@oech3 oech3 commented Oct 25, 2025

No description provided.

@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/cp/copy-FMR. tests/cp/copy-FMR is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/cp/copy-FMR. tests/cp/copy-FMR is passing on 'main'. Maybe you have to rebase?

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 25, 2025

Merging this PR will degrade performance by 4.94%

❌ 2 regressed benchmarks
⏩ 320 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation expand_custom_tabstops[50000] 23.6 ms 24.8 ms -4.94%
Simulation expand_many_lines[100000] 95.9 ms 99.1 ms -3.3%

Comparing oech3:unit1 (ce8c423) with main (107dc44)

Open in CodSpeed

Footnotes

  1. 320 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@oech3 oech3 closed this Oct 25, 2025
@oech3 oech3 deleted the unit1 branch October 25, 2025 09:08
@oech3 oech3 restored the unit1 branch October 25, 2025 12:27
@oech3 oech3 reopened this Oct 25, 2025
@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/cp/copy-FMR. tests/cp/copy-FMR is passing on 'main'. Maybe you have to rebase?

@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/cp/copy-FMR. tests/cp/copy-FMR is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

@oech3 oech3 closed this Oct 26, 2025
@oech3 oech3 deleted the unit1 branch October 26, 2025 08:39
@oech3 oech3 restored the unit1 branch December 9, 2025 12:05
@oech3 oech3 reopened this Dec 9, 2025
@oech3 oech3 marked this pull request as draft December 9, 2025 12:08
@github-actions
Copy link

github-actions bot commented Dec 9, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

@oech3 oech3 closed this Dec 9, 2025
@oech3 oech3 deleted the unit1 branch December 9, 2025 12:39
@github-actions
Copy link

github-actions bot commented Dec 9, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

@oech3 oech3 restored the unit1 branch December 13, 2025 10:11
@oech3 oech3 reopened this Dec 16, 2025
@ChrisDryden
Copy link
Collaborator

Do you have any indication of what is causing shuf lines to be that much slower? I had the exact same issue come up when I did this PR and I haven't been able to find out what happened? #9661 My current belief is that its an issue with our benchmarking

@oech3
Copy link
Contributor Author

oech3 commented Dec 16, 2025

idw... rust-lang/rust#148670

@oech3 oech3 closed this Dec 16, 2025
@oech3 oech3 deleted the unit1 branch December 16, 2025 15:47
@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

@oech3 oech3 reopened this Jan 20, 2026
@oech3

This comment was marked as resolved.

@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)

@oech3 oech3 force-pushed the unit1 branch 3 times, most recently from 9ce50b2 to 7bb78ed Compare January 25, 2026 04:50
@oech3

This comment was marked as resolved.

@oech3 oech3 closed this Jan 25, 2026
@oech3 oech3 deleted the unit1 branch January 25, 2026 06:00
@oech3 oech3 restored the unit1 branch February 5, 2026 13:10
@oech3 oech3 reopened this Feb 7, 2026
@oech3 oech3 force-pushed the unit1 branch 2 times, most recently from 339f710 to 2dd4279 Compare February 8, 2026 14:20
@oech3 oech3 force-pushed the unit1 branch 3 times, most recently from 1638e6f to f6ae1c1 Compare February 10, 2026 09:51
@oech3
Copy link
Contributor Author

oech3 commented Feb 10, 2026

Interesting. codegen-units=3 is OK. 2 cause performance regression.

@oech3 oech3 force-pushed the unit1 branch 3 times, most recently from e972f18 to aa83af0 Compare February 10, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants