Conversation
|
GNU testsuite comparison: |
|
See #7967 for some context |
ac70f46 to
64762d3
Compare
|
thanks for the pointer to the issue @Ecordonnier, i went down that rabbit hole and tried to poc switchable buffering based on rust-lang/rust#78515. closing this until something lands on the rust side. |
Merging this PR will degrade performance by 3.94%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | uniq_heavy_duplicates[10000] |
2 ms | 2.1 ms | -3.94% |
| ⚡ | Memory | uniq_case_insensitive[10000] |
141.9 KB | 16.6 KB | ×8.6 |
| ⚡ | Memory | uniq_heavy_duplicates[10000] |
188.7 KB | 63.3 KB | ×3 |
| ⚡ | Memory | uniq_with_count[10000] |
141.9 KB | 16.6 KB | ×8.6 |
Comparing victor-prokhorov:fix-stdbuf-test-by-fixing-uniq (64762d3) with main (c79e686)
Footnotes
-
46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
fixes stdbuf #10390
main goal is to make gnu stdbuf test pass, i believe the issue is in the uniq