Skip to content

fix(cp): add temporary write/exec perm to built dirs #10859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
my4ng wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(cp): add temporary write/exec perm to built dirs #10859

my4ng wants to merge 2 commits into from
+37 −5

Conversation

@my4ng
Copy link
Contributor

@my4ng my4ng commented Feb 10, 2026

This fixes #10787 by granting temporary u+wx permission when building directory while preserving attributes. The true permission is set dirs_needing_permissions later.

Add test case for the issue.

@my4ng my4ng changed the title fix(cp): add temporary write perm to built dirs fix(cp): add temporary write/exec perm to built dirs Feb 10, 2026
@github-actions
Copy link

github-actions bot commented Feb 10, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/shuf/shuf-reservoir (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/sort/sort-stale-thread-mem (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/pr/bounded-memory is no longer failing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cp -a still fails with readonly directories (follow-up to #7961)

2 participants

@my4ng @sylvestre