Add stickiness_cookie_enabled configuration option#1
Open
Conversation
Decouple the middleware's context lifecycle from cookie persistence so that disabling cross-request cookie stickiness no longer causes thread-local Context to leak between requests in multi-threaded servers. When set to false, the middleware still creates a fresh Context per request (preventing thread-local leaks) but skips reading/writing the arpa_context cookie. Defaults to true for backwards compatibility. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stickiness_cookie_enabledconfiguration option (defaults totruefor backwards compatibility)false, the middleware still creates a freshContextper request (preventing thread-local leaks in multi-threaded servers like Puma) but skips reading/writing thearpa_contextcookieTest plan
configuration_spec.rbtests default value (true) and setterSet-Cookieheader is written, a fresh context is still created, and previous request cookies are not read🤖 Generated with Claude Code