Skip to content

Added the necessary files for building urlmapper into docker images#31

Open
beowulfdk wants to merge 11 commits intomainfrom
feature/docker_images_build
Open

Added the necessary files for building urlmapper into docker images#31
beowulfdk wants to merge 11 commits intomainfrom
feature/docker_images_build

Conversation

@beowulfdk
Copy link
Copy Markdown
Collaborator

No description provided.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 16, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ alain.lehmann
❌ beowulfdk


alain.lehmann seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@beowulfdk beowulfdk marked this pull request as ready for review April 16, 2024 14:10
Comment thread docker/build/cd/Dockerfile Outdated
@chaoticm
Copy link
Copy Markdown
Collaborator

question: Are we going to make a new release out of it? If yes, we'd need to change the version in AssemblyInfo. IMHO this could even be 1.4.

suggestion: Add an information about what the new files are for in https://github.com/unic/SitecoreUrlMapper2/blob/main/be/docs/README.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants