feat(effort): add Merit & Promotion stored procedures for ColdFusion MP#107
feat(effort): add Merit & Promotion stored procedures for ColdFusion MP#107
Conversation
- Add 4 new SPs: sp_person_learning_activities, sp_dept_activity_total_exclude, sp_dept_count_by_job_group_exclude, sp_instructor_evals_average_exclude - Update sp_instructor_activity_exclude and sp_instructor_evals_multiyear to match legacy ColdFusion parameter signatures (MothraId, academic year support) integration- Include usp_getEffortInstructorActivityWithExcludeTerms in Shadow database (used by MP Vote tool)
There was a problem hiding this comment.
Pull request overview
This PR enhances the Effort reporting system's ColdFusion integration by adding 4 new stored procedures for Merit & Promotion workflows and updating 2 existing procedures to match legacy ColdFusion parameter signatures. The changes enable the Shadow database to better support the legacy MP Vote tool and related ColdFusion applications.
Changes:
- Added 4 new stored procedures for ColdFusion Merit & Promotion integration (sp_person_learning_activities, sp_dept_activity_total_exclude, sp_dept_count_by_job_group_exclude, sp_instructor_evals_average_exclude)
- Updated sp_instructor_activity_exclude and sp_instructor_evals_multiyear to support MothraId and academic year parameters
- Removed usp_getEffortInstructorActivityWithExcludeTerms from Shadow database exclusion list to enable MP Vote tool integration
- Applied TRY_CAST defensive parsing pattern to term exclusion logic across multiple procedures
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| web/Areas/Effort/Scripts/EffortSchemaConfig.cs | Removes usp_getEffortInstructorActivityWithExcludeTerms from Shadow database exclusion list to support MP Vote tool |
| web/Areas/Effort/Scripts/CreateEffortReportingProcedures.cs | Adds 4 new Merit & Promotion stored procedures, updates 2 existing procedures with ColdFusion-compatible signatures, and applies defensive TRY_CAST parsing throughout |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Add sp_get_sabbatical_terms for ColdFusion MPVote/VMTH Letter, replacing legacy effort.cfc.Instructor.getInstructorSabbaticTerms() - Fix off-by-one in sp_dept_count_by_job_group_exclude: calendar year end term now correctly uses <= (year+1)*100-1 instead of < (year+1)*100, which was over-counting into the next year
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…iTVF - Replace inline job group filtering in 5 SPs with fn_qualified_job_groups for single source of truth - Fix academic year start term from fall (10) to summer (04) - Rewrite sp_dept_count_by_job_group_exclude with deterministic job group description mappings and effort records check
|
Closing this branch. @bsedwards will need to include this in the JIRA ticket VPR-48 that ports over the Reports, including Merit & Promotion. |
2 participants
Summary
legacy ColdFusion parameter signatures (MothraId, academic year support)
fn_qualified_job_groupsto replace inline job group filtering in 5 SPs