Add Feature: Tiling option menu#452
Open
ochi12 wants to merge 18 commits into
Open
Conversation
this file exports LayoutPicker. A widget where user can hover-select a tile layout. Its current state is purely visual and is not yet integrated with moveHandler.js.
instantiated in TilingMoveHandler class. This commit does not fully integrate layout picker yet but window drag movement is already integrated in this commit.
In this commit window snap now works from layout picker. This commit also includes blocking some snapping behavior when currently picking from the layout picker.
this commit also includes problems fixed which are not shown when animation is not yet implemented, such as layoutPicker shown in random place initially and incorrect visibility trigger bounds. animation focused on translation_y instead of moving the object itself to a new position.
Initially, the main signal triggering update allocation was window-entered-monitor. It was initially thought to be reliable, but this was overlooked. When windows are opened on the same monitor and one is dragged into another monitor, it actually updates the picker position to the other monitor. When I dragged the window left on the first monitor, the picker was still actually placed in the second monitor area.
Author
|
@3v1n0 any thoughts on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #451